document the stopwatch plugin #88
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| foreach ($section->getEvents() as $name => $event) { | ||
| echo sprintf('Request %s took %s ms and used %s bytes of memory', $name, $event->getDuration(), $event->getMemory()); | ||
| } | ||
| } |
There was a problem hiding this comment.
Don't know if this should be here, but Stopwatch plugin can be inconsistent when using async (not the real time, neither memory as it can change if user is doint another async operation). Maybe adding a warning about that (not sure also, don't want to complicate too much the documentation)
There was a problem hiding this comment.
good point. i added a warning at the bottom. i think we better say this
here than have people utterly confused why things don't work as expected
|
LGTM 👍 |
dbu
force-pushed
the
stopwatch-plugin
branch
from
9244947 to
378f627
Compare
sagikazarmark
added a commit
that referenced
this pull request
Feb 19, 2016
document the stopwatch plugin
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #36